Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue and Issue Archive use Media Library images #707

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

patrickbrown-io
Copy link
Contributor

@patrickbrown-io patrickbrown-io commented Feb 29, 2024

Changes the Issue cover image field to use the Media Library images rather than the default. This change requires creating an additional consumer in Focal Image Enable to use un-cropped image styles from JSON:API as well as modifying the Issue Archive, Current Issue Block, and Latest Issue Block build processes to use that un-cropped image.

A spinning loader was also added to the Issue Archive, and Issue Blocks prior to displaying results on page rather than flashing in.

Includes:

Resolves #104

@timurtripp timurtripp self-requested a review March 4, 2024 18:01
Copy link
Contributor

@timurtripp timurtripp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@timurtripp timurtripp merged commit b261a62 into main Mar 4, 2024
5 checks passed
@timurtripp timurtripp deleted the issue/tiamat-custom-entities/104 branch March 4, 2024 18:18
github-actions bot pushed a commit that referenced this pull request Mar 4, 2024
Issue and Issue Archive use Media Library images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue cover image uses an image field rather than a media field
2 participants